Skip to content

Comments

🎨 Palette: Improve accessibility of camera metrics#25

Open
manupawickramasinghe wants to merge 1 commit intomainfrom
palette-accessibility-metrics-10999488797425543971
Open

🎨 Palette: Improve accessibility of camera metrics#25
manupawickramasinghe wants to merge 1 commit intomainfrom
palette-accessibility-metrics-10999488797425543971

Conversation

@manupawickramasinghe
Copy link
Member

This PR enhances the accessibility and discoverability of the camera performance metrics (Frame Time and Bitrate).

Changes:

  1. Tooltips: Added android:tooltipText to the ftFeedback (Frame Time) and qual_feedback (Bitrate) TextViews. This helps users understand what these numbers represent.
  2. Dynamic Content Descriptions: Updated CameraFragment.kt to programmatically set the contentDescription of these TextViews when their values change. Instead of hearing "33ms", screen reader users will now hear "33 milliseconds latency".
  3. Code Cleanup: Removed duplicate android:importantForAccessibility and android:labelFor attributes found in fragment_camera.xml during the process.

Why:
Previously, these metrics were just raw numbers without labels, making them confusing for new users and less accessible for screen reader users. This small polish aligns with the "Palette" philosophy of adding delightful micro-UX improvements.

Verification:

  • Ran ./gradlew assembleDebug successfully.
  • Verified that contentDescription is set using the valid context from the BroadcastReceiver.

PR created automatically by Jules for task 10999488797425543971 started by @manupawickramasinghe

- Added `tooltipText` to frame time and bitrate indicators in `fragment_camera.xml`.
- Added new string resources for tooltips and verbose descriptions.
- Updated `CameraFragment.kt` to set `contentDescription` dynamically for better screen reader experience.
- Cleaned up duplicate attributes in `fragment_camera.xml`.

This improves discoverability for mouse/stylus users and provides semantic context for screen reader users.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant