Skip to content

Modifiable Entries#18

Open
Xaxurro wants to merge 1 commit intoZeioth:masterfrom
Xaxurro:modifiable-entries
Open

Modifiable Entries#18
Xaxurro wants to merge 1 commit intoZeioth:masterfrom
Xaxurro:modifiable-entries

Conversation

@Xaxurro
Copy link

@Xaxurro Xaxurro commented Oct 30, 2024

Hi, this pr removes the data from wofi-emoji and instead stores it on ~/.config/wofi-emoji.rc.

@1ace
Copy link

1ace commented Oct 30, 2024

I'm not sure calling the database wofi-emoji.rc and putting it in ~/.config/ is very accurate 😅

I like the idea of externalising it from the wofi-emoji file though; how about putting it in ~/.cache/wofi-emoji.db instead?

Also, we could move the curl | jq > $CACHED_DB line from build.sh into wofi-emoji, so that removing the cache automatically gets wofi-emoji to re-download the file?

@1ace
Copy link

1ace commented Oct 30, 2024

See #19 for the alternative I'm proposing

@1ace
Copy link

1ace commented Oct 30, 2024

Another argument in favour of having the external file managed by wofi-emoji instead of build.sh is that this removes the need to install build.sh in the wofi-emoji package as compared with this PR which does need that, and it makes it easier for the user to not have to know to run two different commands to populate the db and to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants