You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure calling the database wofi-emoji.rc and putting it in ~/.config/ is very accurate 😅
I like the idea of externalising it from the wofi-emoji file though; how about putting it in ~/.cache/wofi-emoji.db instead?
Also, we could move the curl | jq > $CACHED_DB line from build.sh into wofi-emoji, so that removing the cache automatically gets wofi-emoji to re-download the file?
Another argument in favour of having the external file managed by wofi-emoji instead of build.sh is that this removes the need to install build.sh in the wofi-emoji package as compared with this PR which does need that, and it makes it easier for the user to not have to know to run two different commands to populate the db and to use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this pr removes the data from
wofi-emojiand instead stores it on~/.config/wofi-emoji.rc.