Fix: Prevent spellcast errors when shifting to Bear Form as Druid#4
Open
Xleone1 wants to merge 10 commits intoZedorff:masterfrom
Open
Fix: Prevent spellcast errors when shifting to Bear Form as Druid#4Xleone1 wants to merge 10 commits intoZedorff:masterfrom
Xleone1 wants to merge 10 commits intoZedorff:masterfrom
Conversation
Fix: Prevent spellcast errors when shifting to Bear Form as Druid
Author
|
I'm new to working Git and I realized that all the changes I'm making for my own version of the addon are being included in this PR as well. These can be ignored if you don't want to have them in your version of the addon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a bug for Druids where the
/threatmacro would result in the classic error message:This happened when the addon attempted to cast Druid threat abilities immediately after triggering Bear Form via
CastShapeshiftForm(1). In Vanilla WoW, you cannot cast abilities in the same macro/script call right after shapeshifting, as the form change must complete first.Changes
DruidThreat()toreturnearly after casting Bear Form.Before
After
Result
Druids no longer receive “Another action is in progress” errors. /threat works correctly once already in Bear Form or after shifting finishes.