Release zcash script v0.4.3

[oxarbitrage]

This branch cherry-picks 10 commits from master that affect the zcash_script crate:

• Feature additions (new public APIs)
• Bug fixes (asm formatting)
• Dependency updates (bindgen)
• Documentation fixes
• CI updates

Note: Commit 441b570 ("Remove unnecessary reference operators in test callback calls") was intentionally excluded as it only modifies libzcash_script test code and has no impact on the zcash_script crate being released. It will be included when libzcash_script gets its next release.

Notes:

• Branch zcash_script-v0.4 is an exact copy of tag zcash_script-v0.4.2 (zcash_script-v0.4.2...zcash_script-v0.4). We want to apply the changes on top of that and release from zcash_script-v0.4 or from release-zcash_script-0.4.3

[conradoplg]

Comparing this with main, there is this change missing which seems to be just a clippy fix. Would you mind finding the commit that introduced it and apply it here (or partially apply it, if there are other stuff)?

diff --git a/libzcash_script/src/lib.rs b/libzcash_script/src/lib.rs
index 0ff2b3215c..c445ba6415 100644
--- a/libzcash_script/src/lib.rs
+++ b/libzcash_script/src/lib.rs
@@ -515,7 +515,7 @@ mod tests {
                 true,
                 &|script, flags| {
                     interp
-                        .verify_callback(script, flags)
+                        .verify_callback(&script, flags)
                         .map_err(|err| match err {
                             (t, Error::Script(serr)) => (t, serr),
                             _ => panic!("failed in a very bad way: {:?}", err),
@@ -539,7 +539,7 @@ mod tests {
                         lock_time: 0,
                         is_final: false,
                     })
-                    .verify_callback(script, flags)
+                    .verify_callback(&script, flags)
                     .map_err(|err| match err {
                         (t, Error::Script(serr)) => (t, serr),
                         _ => panic!("failed in a very bad way: {:?}", err),
@@ -551,7 +551,7 @@ mod tests {
                         lock_time: 0,
                         is_final: false,
                     })
-                    .legacy_sigop_count_script(pubkey)
+                    .legacy_sigop_count_script(&pubkey)
                 },
             )
         }

[oxarbitrage]

Comparing this with main, there is this change missing which seems to be just a clippy fix. Would you mind finding the commit that introduced it and apply it here (or partially apply it, if there are other stuff)?

Sorry, i forgot to add the details, now added them to #297 (comment). For that, the reason is:

Commit 441b570 ("Remove unnecessary reference operators in test callback calls") was intentionally excluded as it only modifies libzcash_script test code and has no impact on the zcash_script crate being released. It will be included when libzcash_script gets its next release.

But i am ok with including it if you think it will be better.

[conradoplg]

Comparing this with main, there is this change missing which seems to be just a clippy fix. Would you mind finding the commit that introduced it and apply it here (or partially apply it, if there are other stuff)?

Sorry, i forgot to add the details, now added them to #297 (comment). For that, the reason is:

Commit 441b570 ("Remove unnecessary reference operators in test callback calls") was intentionally excluded as it only modifies libzcash_script test code and has no impact on the zcash_script crate being released. It will be included when libzcash_script gets its next release.

But i am ok with including it if you think it will be better.

Ah nevermind then, I did not realize it was test code. This looks good to me.