Skip to content

Conversation

@Zayan-Mohamed
Copy link
Owner

  • Add download message types and downloadState to track progress, speed and cancellation
  • Implement initiateDownload to download files in chunks over the tunnel and emit progress / error / cancel messages
  • Add progress overlay UI (renderDownloadProgress) with progress bar, speed and cancel hint
  • Prevent UI interactions during active downloads and add ESC key to cancel
  • Keep backward compatibility: downloadFile now routes to the new flow after stat
  • Update styles and helper rendering for progress and status

Files:

  • browser.go

Signed-off-by: Zayan-Mohamed itsm.zayan@gmail.com

Pull Request

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • CI/CD changes

Related Issues

Fixes #

Changes Made

Testing

  • Unit tests pass (make test)
  • Integration tests pass (if applicable)
  • Manual testing completed
  • Tested on multiple platforms (list them below)

Tested On

  • Linux
  • macOS
  • Windows

Security Considerations

  • This change does not weaken encryption, privacy, or isolation
  • No sensitive data is logged or exposed
  • Input validation is properly implemented
  • No new attack vectors are introduced

Security Impact:

Documentation

  • Documentation has been updated (if needed)
  • Code comments added for complex logic
  • CHANGELOG.md updated (for user-facing changes)

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes


By submitting this PR, I confirm that:

  • I have read and agree to the Contributing Guidelines
  • My contribution is made under the project's MIT License
  • I understand that security is paramount and this change maintains Orb's security standards

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 174 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/tui/browser.go 0.00% 174 Missing ⚠️

📢 Thoughts on this report? Let us know!

- Add download message types and downloadState to track progress, speed and cancellation
- Implement initiateDownload to download files in chunks over the tunnel and emit progress / error / cancel messages
- Add progress overlay UI (renderDownloadProgress) with progress bar, speed and cancel hint
- Prevent UI interactions during active downloads and add ESC key to cancel
- Keep backward compatibility: downloadFile now routes to the new flow after stat
- Update styles and helper rendering for progress and status

Files:
- browser.go

Signed-off-by: Zayan-Mohamed <itsm.zayan@gmail.com>
- Use progressFilledStyle for the filled portion of the download progress bar to avoid unused-styles lint error
- Remove the premature return inside the download loop to fix SA4004 (unconditionally terminated loop)
- Remove unused legacy model.downloadFile to resolve unused function lint error
- Remove unused speed var and reformat code; ensure golangci-lint run and go build pass
Signed-off-by: Zayan-Mohamed <itsm.zayan@gmail.com>
Signed-off-by: Zayan-Mohamed <itsm.zayan@gmail.com>
Signed-off-by: Zayan-Mohamed <itsm.zayan@gmail.com>
breaking the CI

Signed-off-by: Zayan-Mohamed <itsm.zayan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants