fix: select most specific launcher instead of first match#537
Merged
wizzomafizzo merged 1 commit intomainfrom Feb 12, 2026
Merged
fix: select most specific launcher instead of first match#537wizzomafizzo merged 1 commit intomainfrom
wizzomafizzo merged 1 commit intomainfrom
Conversation
FindLauncher() used first-match-wins which caused Generic launchers to take precedence over system-specific launchers when they appeared earlier in the array. On Batocera, this meant .sh files in /roms/ports/ launched via Generic (exec.Command) instead of the Ports launcher (esapi.APILaunch). Add specificity scoring (Schemes +1000, Folders +100, SystemID +10) and pick the highest-scoring match. Also reorder Batocera's Generic launcher to appear after esde.SystemMap launchers as defense-in-depth.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FindLauncher()so system-specific launchers (Folders, SystemID, Schemes) take precedence over generic ones — fixes Generic.shlauncher preempting the Portsesapi.APILaunchlauncher on Batoceraesde.SystemMaploop as defense-in-depthCloses #535