fix(mediascanner): isolate SkipFilesystemScan scanners to prevent file wipe#536
Merged
wizzomafizzo merged 1 commit intomainfrom Feb 12, 2026
Merged
fix(mediascanner): isolate SkipFilesystemScan scanners to prevent file wipe#536wizzomafizzo merged 1 commit intomainfrom
wizzomafizzo merged 1 commit intomainfrom
Conversation
…e wipe SkipFilesystemScan launchers (e.g. RetroBat, Kodi) generate results independently and don't filter the shared file list. Previously, the scanner loop used a pipeline where each scanner's output replaced the shared files slice. When an independent scanner ignored its input (like RetroBat's when gamelist.xml is missing), it wiped all files found by other launchers or the filesystem walk. Now SkipFilesystemScan scanners receive nil input and their results are appended, while non-skip scanners retain the existing pipeline behavior.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestNewNamesIndex_IndependentScannerDoesNotWipeFiles(filesystem + independent scanner, verifies both contribute files) and updatedTestNewNamesIndex_MixedSkipFilesystemScanAndCustomLauncherwith a Scanner that returns empty (exact RetroBat scenario).PathIsLauncherandGetSystemPathsfor debugging launcher path resolution.TestParseCustomLaunchers_AbsolutePathWithSystemIDfor custom launcher parsing.Fixes the bug where RetroBat's scanner wiped custom launcher files during PS2 indexing.
Closes #507 and closes #517