fix: discard all failed probes in Safe mode#42
Merged
wizzomafizzo merged 1 commit intomainfrom Feb 7, 2026
Merged
Conversation
Devices using common USB-to-serial chips (CH340, FTDI) were returned as detected PN532 devices in Safe mode even when probing failed, because the isLikelyPN532() guard prevented discarding them. This caused false positives to be cached, blocking detection of real PN532 devices that enumerate later during boot. Remove the isLikelyPN532() guard from the failed-probe branch so Safe mode always discards devices that don't respond to the firmware version probe. A real PN532 behind a CH340 chip will always pass the probe.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isLikelyPN532()guard from the failed-probe branch inprocessPort()so Safe mode always discards devices that don't respond to the firmware version probe1A86:7523, FTDI0403:6001) were returned as detected PN532 devices even when probing failed, causing false positives to be cached and blocking detection of real PN532 devices that enumerate later during bootprocessPortSafe mode behavior via aprobeDeviceFntest seam