Reduce UART probe timeout and cache user data page#38
Merged
wizzomafizzo merged 2 commits intomainfrom Jan 17, 2026
Merged
Conversation
- Reduce per-device UART probe timeout from 2s to 500ms for faster detection when multiple USB-serial devices are present - Cache page 4 (first user data page) during NTAG DetectType for Amiibo detection without additional reads - Skip probe-based detection for non-NDEF tags to avoid NAK errors - Expose GetCachedUserDataPage in tagops for downstream consumers
- Remove detectTypeByProbing function (now unused since non-NDEF tags default to NTAG215 without probing) - Consolidate non-NDEF detection tests into single test verifying default to NTAG215 behavior - Add page 4 mock response to integration test for DetectType flow
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan