perf: optimize SNES identifier to read only ~66KB instead of full file#4
Merged
wizzomafizzo merged 1 commit intomainfrom Dec 10, 2025
Merged
Conversation
The SNES identifier was reading the entire ROM file (256KB-6MB) when it only needs to read up to the HiROM header location (0xFFC0 + 32 bytes). Changes: - Detect SMC header presence by checking file size (size % 1024 == 512) - Calculate read offset to skip SMC header if present - Only read up to ~66KB max instead of the full file This provides approximately 100x reduction in I/O for SNES files while maintaining identical ID generation, matching the original Python GameID behavior.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
The SNES identifier was reading the entire ROM file when it only needs to read up to the HiROM header location (0xFFC0 + 32 bytes). This matches the behavior of the original Python GameID implementation.
Changes
size % 1024 == 512)snesHiROMHeaderStart + snesHeaderSizebytes (~66KB)Test plan