Merged
Conversation
Add comprehensive CHD (Compressed Hunks of Data) V5 format support for game identification across all disc-based consoles: PSX, PS2, PSP, Saturn, Sega CD, Neo Geo CD, and GameCube. New chd package features: - Full CHD V5 header and hunk map parsing - Codec support: zlib (cdzl), LZMA (cdlz), FLAC (cdfl), Zstandard (cdzs) - Bitstream reader for Huffman-encoded hunk maps - Track metadata parsing (CHT2, CHTR, CHCD formats) - Sector readers for both raw (2352-byte) and ISO (2048-byte) access - Automatic data track detection for multi-track CDs - Hunk caching for performance - DoS protection via allocation limits (MaxNumHunks, MaxCompMapLen, etc.) - Circular metadata chain detection Integration: - iso9660 package refactored to use io.ReaderAt for CHD compatibility - New iso9660.OpenCHD() adapter for seamless filesystem access - All disc-based identifiers updated with .chd extension support - Console detection via raw sector magic bytes and ISO9660 analysis Tested against 648 real CHD files with 100% identification success rate (516 PSX, 82 Saturn, 50 Sega CD).
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Add comprehensive unit tests covering: - CHD codecs (zlib, lzma decompression and error handling) - CHD header parsing (V3/V4 formats) - CHD metadata parsing (CHTR, CHCD formats) - CHD circular metadata chain detection - ISO9660 OpenCHD, OpenReaderWithCloser, GetDataPreparerID - Console detection from CHD files (SegaCD, NeoGeoCD, GameCube) - IdentifyFromReader function - identifyFromDirectory for disc-based and cartridge consoles Also add nolint directives for gosec G602 false positives in codec_lzma.go and codec_zlib.go where bounds are already validated. Coverage improved from ~61% to 65.9% overall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive CHD (Compressed Hunks of Data) V5 format support for game identification across all disc-based consoles.
chdpackage with full CHD V5 parsingChanges
New Package:
chd/header.go- CHD V5 header parsinghunk.go- Hunk map parsing and cachingmetadata.go- Track metadata (CHT2, CHTR, CHCD formats)codec_*.go- Compression codec implementationsbitstream.go- Huffman decoder for V5 mapserrors.go- Error types and allocation limitsModified Files
iso9660/iso9660.go- Refactored to useio.ReaderAtfor CHD compatibilityiso9660/chd.go- New adapter for CHD→ISO9660console.go- CHD detection logicidentifier/*.go- Added.chdextension support to all disc identifiersDependencies
github.com/klauspost/compress- Zstandardgithub.com/mewkiz/flac- FLACgithub.com/ulikunitz/xz- LZMA (v0.5.15, patched for GO-2025-3922)Test plan
make check)