Added shakespeare-insult-kit as an alternative. #1
Open
mattmarkwick wants to merge 2 commits intoZackFreedman:mainfrom
Open
Added shakespeare-insult-kit as an alternative. #1mattmarkwick wants to merge 2 commits intoZackFreedman:mainfrom
mattmarkwick wants to merge 2 commits intoZackFreedman:mainfrom
Conversation
mattmarkwick
changed the title
Owner
|
I like the idea, but not how it renames all the word lists. It would be better to move the word lists to separate files, and allow the user to append/include the ones they want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My fiancee makes crochet soft toys, so after seeing your videos on Misty & Christopher I knew immediately that I needed to put an insult generator inside one of them.
Her first question was can it do Shakespearean insults?
So I've added the insults from the commonly found shakespeare-insult-kit as a separate option. Wasn't sure whether to keep them entirely separate or try to incorporate into the already established insults. So for now this is just a simple addition.
I also moved the lists into separate files.
I won't be insulted if you choose not to merge this.... so hopefully you do, and then I'll be super insulted, my friends will be insulted, my cat will be insulted, my family will.... you get the picture.