Open
Conversation
…detect androidTest
|
Any reason for not merging this to main? |
Owner
|
This isn't a project I actively maintain or check, sorry. I'll take a look soon. Please don't assume it's been intentionally ignored, open source is usually spare time and things slip :) |
Author
|
I was unable to update Kotlin to 1.8, it didn't work for some reason: it was complaining on the function with empty body for |
Author
|
Kotlin update on 1.8.10 worked, luckily. There was a bug in compiler that was causing the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a liberty to update versions of everything. Some Gradle plugins broke (e.g. Shadow doesn't seem to work, but I'm not sure about it) or got obsolete, so I removed them.
Unfortunately, for some reason Studio didn't want to see Android benchmarks, so I had to extract them to the top level module, hope that's OK.
As an extra, I've added some useful Gradle properties to speed up builds. Not sure if they can affect benchmark results, most likely not, but it can improve build times at least.