story(issue-633): implement post machines endpoint#638
Draft
Conversation
11 tasks
Zaba505
commented
Nov 26, 2025
Owner
Author
There was a problem hiding this comment.
this can be removed since it doesn't actually test anything
Owner
Author
There was a problem hiding this comment.
This should be a reusable pacakge for all services so move it to a top level package path of pkg/api
| return invalidFields | ||
| } | ||
|
|
||
| func ValidateMACAddress(mac string) error { |
Owner
Author
There was a problem hiding this comment.
this shouldn't be public since its only used in this package
Owner
Author
There was a problem hiding this comment.
This should be a single test function, TestPostMachines, which is table driven and for each test uses PostMachines() to configure a rest.Api that created in the test case. Then the rest.Api is passed to httptest.Server so that all test cases are actually tests against the full endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #633