Conversation
steppable::__internals::arithmetic -> steppable::__internals::calc
steppable::__internals::arithmetic -> steppable::__internals::calc
- [BREAKING] `radToDeg` and `degToRad` now require a `const int decimals` parameter, - `multiply` now takes a `const int decimals` parameter - `multiply` will now automatically round both numbers to desired precision before calculating the product, in order to reduce computation .
ZCG-coder
added
T-Feature
- Faster decimal power through `exp` and `ln` - More accurate `exp` by fixing a rounding bug - [DEV] Allow building all tests with `make tests` - Allow `decimal` option in `power`
This was
linked to
issues
Feb 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #52 #53 and #54. It brings the following to Steppable:
powerwith a new approximation method.multiplyandpowerThis PR is not backwards-compatible with older code, as
steppable::__internals::arithmeticis renamed tosteppable::__internals::calcChangelog
rounding_modesteppable::__internals::arithmeticsteppable::__internals::arithmetic -> steppable::__internals::calc
steppable::__internals::arithmeticsteppable::__internals::arithmetic -> steppable::__internals::calc
Resultto replace std::string.multiplyradToDeganddegToRadnow require aconst int decimalsparameter,multiplynow takes aconst int decimalsparametermultiplywill now automatically round both numbers to desiredprecision before calculating the product, in order to reduce computation
.
powersign issuemultiplyexpandlnexpby fixing a rounding bugmake testsdecimaloption inpowerdecimaloption to bindings