Fix false positive in proxy/fastcgi param tests#183
Open
Conversation
False positive. For instance you have 3 nginx config file and in one you have the proxy_params_auth configuration. So we have sso = true in the manifest, we should check that at last one nginx config have proxy_params_auth, so not for all nginx config file.
We should be more tolerant when there are custom fastcgi_param and proxy_set_header. In some case it could be justified to override the default value. For now I created a blacklist of the param that there are no reason to override and a list of the param that it could make sens to override. Also now we check if the value is the default one, so if it's the default one there no reason to override and we rise a warning.
8be3d2f to
7863840
Compare
Salamandar
approved these changes
Feb 11, 2026
Contributor
Salamandar
left a comment
There was a problem hiding this comment.
LGTM although reusing the variable name reverse_proxy_params_from_includes_that_are_manually_set sounds a bit fishy.
Waiting for a second opinion on the list of variables / values but it should be OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
proxy_params_authconfiguration. So we havesso = truein the manifest, we should check that at last one nginx config haveproxy_params_auth, so not for all nginx config file.PR checklist