Fix upgrade by CodeShakingSheep · Pull Request #219 · YunoHost-Apps/roundcube_ynh

CodeShakingSheep · 2024-08-10T20:13:38Z

Don't replace config file

Problem

After the last update the contextmenu extension wasn't working anymore as the config/config.inc.php file had been overridden from the template file leading to the installed extensions not being present anymore after this line: https://github.com/YunoHost-Apps/roundcube_ynh/blob/master/conf/config.inc.php#L140

Solution

Keep config/config.inc.php and don't override it with the template.

PR Status

Code finished and ready to be reviewed/tested
The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Don't replace config file

CodeShakingSheep · 2024-08-10T20:14:20Z

!testme

yunohost-bot · 2024-08-10T20:14:23Z

🌻

yunohost-bot · 2024-08-10T20:14:23Z

📚

Keep composer.json

CodeShakingSheep · 2024-08-10T20:56:39Z

!testme

yunohost-bot · 2024-08-10T20:56:42Z

Alrighty!

yunohost-bot · 2024-08-10T20:56:43Z

🐛

Keep composer.lock

CodeShakingSheep · 2024-08-10T22:22:08Z

!testme

yunohost-bot · 2024-08-10T22:22:12Z

May the CI gods be with you!

yunohost-bot · 2024-08-10T22:22:12Z

📚 🐛

--keep option doesn't support wildcards

CodeShakingSheep · 2024-08-10T22:52:54Z

!testme

yunohost-bot · 2024-08-10T22:52:57Z

📖

yunohost-bot · 2024-08-10T22:52:57Z

Meow 🐈

CodeShakingSheep · 2024-08-10T23:37:28Z

Meow 🐈

Upgrades fail because of an already existing table collected_contacts. Created a PR for it sblaisot/automatic_addressbook#31

ericgaspar · 2026-02-10T22:34:44Z

!testme

yunohost-bot · 2026-02-10T22:34:47Z

🚀

ericgaspar · 2026-02-11T13:35:45Z

!testme

yunohost-bot · 2026-02-11T13:35:49Z

📖 🪱

CodeShakingSheep · 2026-02-11T18:28:36Z

Hey @ericgaspar ,
Thanks for all your work with roundcube packaging! The RC plugin which makes the upgrade test fail is https://github.com/sblaisot/automatic_addressbook which has been last updated 10(!) years ago. Back then I created a PR in the repo (sblaisot/automatic_addressbook#31) but the project seems completely dormant.

Anyways, since Roundcube 1.5 email addresses of recipients are collected automatically, see https://kolabian.wordpress.com/2020/09/26/collected-recipients-and-trusted-senders/ and roundcube/roundcubemail#6904 . So, what the problematic plugin did became a Roundcube core feature. Therefore, I'd suggest to just remove the plugin. What do you think?

Also, I saw that you updated PHP version to 8.5 in your latest PR. That might be a bit too soon as full PHP 8.4 support will come with RC 1.7, see https://roundcube.net/news/2025/07/14/roundcube-1.7-beta-released . So, I think in 1.6 we should stick to PHP 8.3 for now.

CodeShakingSheep · 2026-02-18T18:29:07Z

!testme

yunohost-bot · 2026-02-18T18:29:10Z

📖 🪱

@CodeShakingSheep

* Update carddav version to 5.1.2 (YunoHost-Apps#248) * [autopatch] Automatic patch to simplify `proxy_pass`/`fastcgi_pass` options in nginx.conf (PLEASE DOUBLE CHECK BEFORE MERGING) (YunoHost-Apps#246) Co-authored-by: Yunohost-Bot <> * [autopatch] Automatic patch to use nodejs/ruby/go/compose resources + remove empty _common.sh (YunoHost-Apps#240) * [autopatch] Automatic patch to use nodejs/ruby/go/compose resources + remove empty _common.sh * Update manifest.toml --------- Co-authored-by: Yunohost-Bot <> Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com> * Upgrade to v1.6.13 (YunoHost-Apps#250) * Upgrade sources - `main` v1.6.13: https://github.com/roundcube/roundcubemail/releases/tag/1.6.13 * Auto-update READMEs * fix(composer): readd composer resource * fix(apt): explicitely list php8.3 in dependencies * Update manifest.toml * Update manifest.toml * Update _common.sh * Update _common.sh * 2.1 (YunoHost-Apps#252) * 2.1 * cleaning * cleaning * Update install * Update install * Update upgrade * Update manifest.toml * Update tests.toml * Update upgrade * Update upgrade * Update upgrade * Update upgrade * Update install * Update manifest.toml * Update manifest.toml * Update manifest.toml * cleaning * Update upgrade * Update upgrade * fix YunoHost-Apps#233 nextcloud carddav default configuration (YunoHost-Apps#234) Co-authored-by: Pierre Réveillon <p.reveillon@apimoov.fr> * Update manifest.toml * Update ADMIN.md * Update nginx.conf * Update upgrade * Update manifest.toml * Upgrade sources - `main` v1.6.14: https://github.com/roundcube/roundcubemail/releases/tag/1.6.14 * Auto-update READMEs * Update install add timezone * Update config.inc.php add domain timezone * Update upgrade add timezone * bug fix upgrade 1.6.11 to 1.6.12/13 (YunoHost-Apps#257) * Testing (YunoHost-Apps#251) * Update carddav version to 5.1.2 (YunoHost-Apps#248) * [autopatch] Automatic patch to simplify `proxy_pass`/`fastcgi_pass` options in nginx.conf (PLEASE DOUBLE CHECK BEFORE MERGING) (YunoHost-Apps#246) Co-authored-by: Yunohost-Bot <> * [autopatch] Automatic patch to use nodejs/ruby/go/compose resources + remove empty _common.sh (YunoHost-Apps#240) * [autopatch] Automatic patch to use nodejs/ruby/go/compose resources + remove empty _common.sh * Update manifest.toml --------- Co-authored-by: Yunohost-Bot <> Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com> * Upgrade to v1.6.13 (YunoHost-Apps#250) * Upgrade sources - `main` v1.6.13: https://github.com/roundcube/roundcubemail/releases/tag/1.6.13 * Auto-update READMEs * fix(composer): readd composer resource * fix(apt): explicitely list php8.3 in dependencies * Update manifest.toml * Update manifest.toml * Update _common.sh * Update _common.sh * 2.1 (YunoHost-Apps#252) * 2.1 * cleaning * cleaning * Update install * Update install * Update upgrade * Update manifest.toml * Update tests.toml * Update upgrade * Update upgrade * Update upgrade * Update upgrade * Update install * Update manifest.toml * Update manifest.toml * Update manifest.toml * cleaning * Update upgrade * Update upgrade * fix YunoHost-Apps#233 nextcloud carddav default configuration (YunoHost-Apps#234) Co-authored-by: Pierre Réveillon <p.reveillon@apimoov.fr> * Update manifest.toml * Update ADMIN.md * Update nginx.conf * Update upgrade --------- Co-authored-by: CodeShakingSheep <19874562+CodeShakingSheep@users.noreply.github.com> Co-authored-by: YunoHost Bot <yunohost-bot@users.noreply.github.com> Co-authored-by: tituspijean <tituspijean@yunohost.org> Co-authored-by: DeMiro5001 <68397534+DeMiro5001@users.noreply.github.com> Co-authored-by: Grubshka <pierre@lail.fr> Co-authored-by: Pierre Réveillon <p.reveillon@apimoov.fr> * bug fix upgrade 1.6.11 to 1.6.12/13 * Apply suggestion from @CodeShakingSheep Co-authored-by: CodeShakingSheep <19874562+CodeShakingSheep@users.noreply.github.com> --------- Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com> Co-authored-by: CodeShakingSheep <19874562+CodeShakingSheep@users.noreply.github.com> Co-authored-by: YunoHost Bot <yunohost-bot@users.noreply.github.com> Co-authored-by: tituspijean <tituspijean@yunohost.org> Co-authored-by: DeMiro5001 <68397534+DeMiro5001@users.noreply.github.com> Co-authored-by: Grubshka <pierre@lail.fr> Co-authored-by: Pierre Réveillon <p.reveillon@apimoov.fr> * Upgrade to v1.6.15 (YunoHost-Apps#268) --------- Co-authored-by: CodeShakingSheep <19874562+CodeShakingSheep@users.noreply.github.com> Co-authored-by: YunoHost Bot <yunohost-bot@users.noreply.github.com> Co-authored-by: tituspijean <tituspijean@yunohost.org> Co-authored-by: DeMiro5001 <68397534+DeMiro5001@users.noreply.github.com> Co-authored-by: Grubshka <pierre@lail.fr> Co-authored-by: Pierre Réveillon <p.reveillon@apimoov.fr> Co-authored-by: yunohost-bot <yunohost@yunohost.org> Co-authored-by: Robles Rodolphe <rodolphe.robles@sfr.fr> Co-authored-by: orhtej2 <2871798+orhtej2@users.noreply.github.com> Co-authored-by: 1Dimitri <13608395+1Dimitri@users.noreply.github.com>

CodeShakingSheep · 2026-04-06T21:53:10Z

!testme

yunohost-bot · 2026-04-06T21:53:14Z

Remember: a failing test is just a misunderstood spicy feature!

CodeShakingSheep · 2026-04-06T22:44:32Z

@ericgaspar I updated this branch and added some fixes. This should fix #259 . Can you merge it?

Update upgrade

6d1802e

Don't replace config file

CodeShakingSheep changed the base branch from master to testing August 10, 2024 20:13

Update upgrade

e730c4a

Keep composer.json

Update upgrade

b15a3b7

Keep composer.lock

Update upgrade

ad73b34

--keep option doesn't support wildcards

CodeShakingSheep marked this pull request as draft August 28, 2024 21:00

ericgaspar added 2 commits September 1, 2024 15:07

Merge branch 'testing' into pr/219

61630ff

Merge branch 'testing' into pr/219

723d2b5

ericgaspar added 2 commits February 10, 2026 23:41

Update upgrade

73792a0

cleaning

d9e098b

Update tests.toml

24aa74f

Merge branch 'testing' into no-config-override

ba1c8fc

Don't run composer install during upgrade

cc2f9a6

CodeShakingSheep and others added 5 commits February 18, 2026 14:52

Keep vendor dir

2eca836

Don't require rc plugin installer again

e698a40

Merge branch 'testing' into no-config-override

ab0f371

Merge branch 'YunoHost-Apps:master' into no-config-override

805394e

Update JS deps

a10ae9d

CodeShakingSheep marked this pull request as ready for review April 6, 2026 22:43

Conversation

CodeShakingSheep commented Aug 10, 2024

Problem

Solution

PR Status

Automatic tests

Uh oh!

CodeShakingSheep commented Aug 10, 2024

Uh oh!

yunohost-bot commented Aug 10, 2024

Uh oh!

yunohost-bot commented Aug 10, 2024

Uh oh!

CodeShakingSheep commented Aug 10, 2024

Uh oh!

yunohost-bot commented Aug 10, 2024

Uh oh!

yunohost-bot commented Aug 10, 2024

Uh oh!

CodeShakingSheep commented Aug 10, 2024

Uh oh!

yunohost-bot commented Aug 10, 2024

Uh oh!

yunohost-bot commented Aug 10, 2024

Uh oh!

CodeShakingSheep commented Aug 10, 2024

Uh oh!

yunohost-bot commented Aug 10, 2024

Uh oh!

yunohost-bot commented Aug 10, 2024

Uh oh!

CodeShakingSheep commented Aug 10, 2024

Uh oh!

ericgaspar commented Feb 10, 2026

Uh oh!

yunohost-bot commented Feb 10, 2026

Uh oh!

ericgaspar commented Feb 11, 2026

Uh oh!

yunohost-bot commented Feb 11, 2026

Uh oh!

CodeShakingSheep commented Feb 11, 2026

Uh oh!

CodeShakingSheep commented Feb 18, 2026

Uh oh!

yunohost-bot commented Feb 18, 2026

Uh oh!

CodeShakingSheep commented Apr 6, 2026

Uh oh!

yunohost-bot commented Apr 6, 2026

Uh oh!

CodeShakingSheep commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants