Fix upgrade script

[HugoPoi]

Problem

• Fix Failed upgrade from 1.6.0~ynh4 to 1.6.6~ynh1 #193

Solution

• Common process for install and upgrade
• Start cleanup composer deps update

PR Status

• Code finished and ready to be reviewed/tested
  • fix /usr/share/yunohost/helpers.d/logging: line 328: $left_progression: substring expression < 0
  • Add proper progression steps
  • Fix

    Warning: In Factory.php line 697:
    Warning:   The HOME or COMPOSER_HOME environment variable must be set for composer to run correctly
    Warning: update [--with WITH] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-dev] [--lock] [--no-install] [--no-audit] [--audit-format AUDIT-FORMAT] [--no-autoloader] [--no-suggest] [--no-progress] [-w|--with-dependencies] [-W|--with-all-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-i|--interactive] [--root-reqs] [--] [<packages>...]
    Warning: Executing database schema update.
    Warning: Executing php composer.phar to update dependencies...
    Warning: -----------------------------------------------------------------------------
    Warning: ATTENTION: Update dependencies by running `php composer.phar update --no-dev`
    Warning: -----------------------------------------------------------------------------
    Warning: This instance of Roundcube is up-to-date.
    Warning: Have fun!
    

• The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[ericgaspar]

!testme

[yunohost-bot]

May the CI gods be with you!

[HugoPoi]

Someone know why we don't have /var/www/roundcube/composer.phar after ynh_install_composer ?

[HugoPoi]

• I made some progress yesterday testing
• Commit 0382965 is fixing the bug and working
• Then I refactor everything to clean up linter issues, but now it's broken there is a cascading tunnel of error with composer, I didn't find why my first attempt work, I need to look deeper between 0382965 and c913078
• And I didn't had time to look into the upgrade issue of the CI

[ericgaspar]

!testme

[yunohost-bot]

Meow 🐈