Tests: fix by using another package and only request the container#66
Merged
alexAubin merged 1 commit intoYunoHost-Apps:testingfrom Sep 22, 2025
Merged
Tests: fix by using another package and only request the container#66alexAubin merged 1 commit intoYunoHost-Apps:testingfrom
alexAubin merged 1 commit intoYunoHost-Apps:testingfrom
Conversation
Member
|
By the power of systemd, I invoke The Great App CI to test this Pull Request! |
Contributor
|
Test it, book it, worm it, technologic. 🤖 🎶 |
fflorent
commented
Sep 21, 2025
| # } | ||
| # location = /path__2 { | ||
| # return 200 "This is /path__2 for redirect_ynh CI purposes!"; | ||
| # } |
Contributor
Author
There was a problem hiding this comment.
Note to the reviewers: probably worth to remove this in yunohost.org's nginx config
|
|
||
| preinstall = """ | ||
| yunohost domain add target.domain.tld | ||
| yunohost app install https://github.com/YunoHost-Apps/helloworld_ynh -a "domain=target.domain.tld&path=/&init_main_permission=visitors" --force |
Contributor
Author
There was a problem hiding this comment.
Even if it is tricky, I find helloworld_ynh convenient to avoid creating a whole nginx config + create all the index files.
Contributor
Author
|
@alexAubin Sounds it works! |
Contributor
Author
|
!testme |
Contributor
|
Test it, book it, worm it, technologic. 🤖 🎶 |
alexAubin
approved these changes
Sep 22, 2025
Contributor
Author
|
(@alexAubin I don't have the rights to merge by myself, if you would like to either grant me this right or to do that yourself! 🙏 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #65
Solution
Prerequisite: This patch requires YunoHost/package_check#201
I feel like requesting the package requires the access to the internet for convenient reason, but due to this commit YunoHost/package_check@f120010, it is not the case anymore. Also it requires some tweaks on the yunohost.org server side.
I suggest to install the dummier package possible that serves static files, I have chosen for that
helloworld_ynhto let the tests have a final destination.PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)