add support for custom data directory

[oiseauroch]

Problem

I configured my nextcloud with custom data directory and upgrade failed due to hardcoded data directory.

Solution

Instead of using hardcoded path, I look for the data directory in the config file of nextcloud.

PR Status

• Code finished.
• Tested with Package_check.
• Fix or enhancement tested.
• Upgrade from last version tested.
• Can be reviewed and tested.

Validation

---

Minor decision

• Upgrade previous version :
• Code review :
• Approval (LGTM) :
• Approval (LGTM) :

Package_check results

---

• An automatic package_check will be launch at https://ci-apps-dev.yunohost.org/, when you add a specific comment to your Pull Request: "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!"*

[oiseauroch]

!testme

[yunohost-bot]

😜

[MayeulC]

Probably fixes the issue I had: #485 👍

[ericgaspar]

!testme

[yunohost-bot]

Fingers crossed!

[artybdrlt]

Hello. Any news on this PR?

[ericgaspar]

!testme

[yunohost-bot]

Fingers crossed!

[ericgaspar]

!testme

[yunohost-bot]

✌️

[alexAubin]

Hmmm we gotta be careful with this, this is gonna create weird behavior in packaging v2 context. For example the behavior of the --purge option of yunohost app remove is coupled to the data_dir setting. So one way or another, the value of the setting should be synced with the value of the conf file

It's still not clear to me what's the recommended way of having a custom data location (for this app or others) between changing the app's data_dir setting, or using mount bind, or other things. I would tend to think that a mount bind is a far better option though