Fixed config overwrite and update version#2
Open
jwidess wants to merge 2 commits intoYuWan-030:masterfrom
Open
Fixed config overwrite and update version#2jwidess wants to merge 2 commits intoYuWan-030:masterfrom
jwidess wants to merge 2 commits intoYuWan-030:masterfrom
Conversation
Fixed overwriting existing config file on every start of the mod. Now changes to the config will actually persist.
trueuuid library from 1.0.2 to 1.0.5 in build.gradle and changed mod_version to 1.0.3 in gradle.properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
config.jsonfrom being overwritten with defaults on every start of the mod. Now it properly loads the config if it exists. I also updated the trueuuid dependency to v1.0.5 and incremented the mod version to 1.0.3.NOTE: This functionality already seems to have been implemented in v1.0.3 that is uploaded on Modrinth here, so not sure if something hasn't been committed or what... I say this as using that 1.0.3 version, I had no problems modifying the config, but now, compiling my own version of the mod, I was running into this issue.
AI Overview Below: