Fix checking for connection to master network#225
Merged
JackOfMostTrades merged 1 commit intoYourDeveloperFriend:mainfrom Feb 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the map designer, the check that all track must be connected to the master network happens at the end of the build phase. If this connectivity is checked as each tile is placed, there are circumstances where builds are not allowed but should be.
In this example, it is valid for a player to build from Henri-Bourassa to Montmorency. However, a player is not allowed to start the build at the town since the base game build-by-build checks that track all leads back to a city over the current player's track. The prior check for this map also would not have allowed the player to start the build from Henri-Bourassa since the first track placement would not have been connected to the master network.
This PR replaces the prior build-by-build check for connectivity to the master network with an end-of-build-phase check that validates that all track is connected.