Skip to content

Refactor GoodsTable layout and add readGoodColor utility for dynamic good color retrieval #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lordscarlet wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Refactor GoodsTable layout and add readGoodColor utility for dynamic good color retrieval #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
533270c
Refactor GoodsTable layout and add readGoodColor utility for dynamic …
lordscarlet Aug 23, 2025
aada8b3
Update test command to use Jasmine for running tests
lordscarlet Aug 23, 2025
6b15d0d
Update test command to use npx for running Jasmine tests
lordscarlet Aug 23, 2025
7d4aead
Revert test.yml to it's previous state
lordscarlet Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 117 additions & 4 deletions src/client/game/goods_table.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,49 @@
gap: 4px;
}

.row > *,
.column > * {
.row > * {
flex: 1;
text-align: center;
}

/* column children should not stretch vertically; columns are fixed-width stacks */
.column > * {
flex: none;
text-align: center;
}

/* layout for the two groups: White and Black */
.groupsGrid {
display: grid;
grid-template-columns: 1fr 1fr;
gap: 32px;
align-items: start;
justify-items: center;
}

.group {
display: flex;
flex-direction: column;
align-items: center;
}

.groupHeader {
margin: 0 0 8px 0;
font-size: 18px;
text-align: center;
height: 36px;
display: flex;
align-items: center;
justify-content: center;
box-sizing: border-box;
}

.goodPlace {
aspect-ratio: 1 / 1;
background-color: var(--good-color);
width: 28px;
height: 28px;
display: block;
/* prefer the --good-color variable set by good classes, fall back to lightgrey */
background-color: var(--good-color, lightgrey);
}

.empty {
Expand All @@ -45,3 +79,82 @@
.gapRight {
margin-right: 8px;
}

.blackColumn {
background-color: #333;
padding: 12px 6px 12px 6px;
border-radius: 4px;
}

.blackHeader {
background-color: #333;
color: white;
padding: 6px 8px;
border-radius: 6px;
}

.headerCell {
display: flex;
justify-content: center;
align-items: center;
padding: 2px 0;
height: 26px;
}

.letterCell {
display: flex;
justify-content: center;
align-items: center;
padding: 2px 0;
height: 26px;
}

/* keep header cell positioned naturally inside the black column so it has breathing room */
.blackColumn > .headerCell {
margin-top: 0;
}

/* Ensure letter placeholders in black columns align with others */
.blackColumn > .letterCell {
margin-top: 0;
}

/* layout wrappers for grouped columns (white / black) */
.leftColumns,
.rightColumns {
display: flex;
gap: 8px;
align-items: flex-start;
flex: none; /* don't stretch to fill the row */
flex-wrap: nowrap;
padding-top: 10px; /* breathing room above the first row of header hexes */
}

.rightColumns {
margin-left: 8px;
}

/* make each column a fixed-size stack so groups line up */
.column {
width: 52px;
flex: none;
display: flex;
flex-direction: column;
gap: 6px;
align-items: center;
}

/* apply the same internal padding to white columns so header hexes have breathing room inside the white stacks */
.leftColumns > .column {
padding: 12px 6px 12px 6px;
box-sizing: border-box;
}

/* placeholder used to reserve header space when there's no visible letter header */
.headerPlaceholder {
width: 32px;
height: 29px;
}
.headerPlaceholderHidden {
visibility: hidden;
}
Loading
Loading