Patch RF to handle root with single descendant #282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@isabellechan089 your
_robinson_foulds_bitsetimplementation raises an error when the root has a single descendant becauseleaves1 = sorted([n for n in tree1 if tree1.degree[n] == 1])will incorrectly include it in the leaf set. I've patched it here but let's watch out for this failure mode in the future and be sure to include more tree topologies in the tests.