-
Notifications
You must be signed in to change notification settings - Fork 28
Spatial tutorial #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spatial tutorial #262
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 79.77% 74.91% -4.87%
==========================================
Files 91 94 +3
Lines 8347 8454 +107
==========================================
- Hits 6659 6333 -326
- Misses 1688 2121 +433 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
colganwi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @mattjones315! My major comment is that its not worth adding squidpy as a dependency just for the spatial_neighbors method. Users can precompute the neighborhood graph before running impute_spatial_data.
This PR implements the framework for a spatial library. Already, there were pieces of this library such as the
ClonalSpatialDataSimulator; here, we implement a separate module -spatial- which currently implements a spatial imputation procedure.We also include a tutorial notebook for the spatial data.