Skip to content

Conversation

@mattjones315
Copy link
Collaborator

This PR implements the framework for a spatial library. Already, there were pieces of this library such as the ClonalSpatialDataSimulator; here, we implement a separate module - spatial - which currently implements a spatial imputation procedure.

We also include a tutorial notebook for the spatial data.

@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

❌ Patch coverage is 78.26087% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.91%. Comparing base (8bbcd10) to head (8b36987).
⚠️ Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
cassiopeia/spatial/spatial_utilities.py 62.85% 13 Missing ⚠️
cassiopeia/preprocess/utilities.py 81.48% 5 Missing ⚠️
cassiopeia/spatial/spatial_imputation.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   79.77%   74.91%   -4.87%     
==========================================
  Files          91       94       +3     
  Lines        8347     8454     +107     
==========================================
- Hits         6659     6333     -326     
- Misses       1688     2121     +433     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattjones315 mattjones315 requested a review from colganwi July 23, 2025 18:39
Copy link
Collaborator

@colganwi colganwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @mattjones315! My major comment is that its not worth adding squidpy as a dependency just for the spatial_neighbors method. Users can precompute the neighborhood graph before running impute_spatial_data.

@mattjones315 mattjones315 merged commit c8207bc into master Jul 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants