Bug fix: Use clustered lineage profile for indel color generation #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ered version The function creates clustered_linprof (line 520) which is a filtered version of the lineage profile containing only the specified leaves, the bug consists in the use the original lineage_profile to generate colors (line 522) instead of the filtered clustered_linprof.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed inconsistency in
prepare_alleletable()where indel colors were generated from the full lineage profile instead of the filteredclustered_linprof. This ensures color generation is based on the same subset of data that gets returned for plotting. This resulted in an error when trying to retrieve data from an indel in the wrong scope.For example in line cassiopeia/plotting/local.py:239:
The function in its original form creates clustered_linprof (line 520) which is a filtered version of the lineage profile containing only the specified leaves, the bug consists in the use the original lineage_profile to generate colors (line 522) instead of the filtered clustered_linprof.