Added filters, new nginx parser #9
Open
+109
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows setting a prefix using PARSIBLE_STATSD_PREFIX env variable
Contributor
There was a problem hiding this comment.
any particular reason for the () around self.should_filter?
Author
There was a problem hiding this comment.
Nope, just that I'm new to python and a bit confused on some of it's syntax
:)
On Wed, Jun 10, 2015 at 6:46 AM, Andrew Gross notifications@github.com
wrote:
In parsible.py
#9 (comment):@@ -187,9 +204,13 @@ def main(self):
# Abstract all the messy generator logic away into a simple for-each for parsed_line in parsed_log_file:
if(self.should_filter(parsed_line)):any particular reason for the () around self.should_filter?
—
Reply to this email directly or view it on GitHub
https://github.com/Yipit/parsible/pull/9/files#r32061831.
Contributor
There was a problem hiding this comment.
No worries, overall this looks pretty good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is that I've added support for filters, so you can skip your 4xx status codes (which most of the times are related to bots scanning for phpmyadmin or such).
I am aware that's not the most optimal setup, and I'm open to suggestions. I'll be adding other filters, that are not that general (e.g. filter out js/css/etc requests), and it would be nice if everyone would be able to add their own parsers, without requiring others to run them.