This repository was archived by the owner on May 13, 2025. It is now read-only.
[Bugfix] Handle Situation Where No Password Given#4
Open
etscrivner wants to merge 1 commit intoYelpArchive:masterfrom
Open
[Bugfix] Handle Situation Where No Password Given#4etscrivner wants to merge 1 commit intoYelpArchive:masterfrom
etscrivner wants to merge 1 commit intoYelpArchive:masterfrom
Conversation
* Presently, if no password is given, the XORCrypter produces a DivideByZero error. This patch adds correct handling for this situation as well as a unit-test to verify that it works. This has already been tested in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DivideByZero error. This patch adds correct handling for this
situation as well as a unit-test to verify that it works. This has
already been tested in production against Nagios 2.7.2 and 2.9.1.