Support partial templates in smartstack.yaml #4148
Open
+305
−293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
previously approved these changes
Nov 11, 2025
nemacysts
reviewed
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our old smartstack schema validation was a bit jank, and ended up requiring things like https://github.yelpcorp.com/sysgit/yelpsoa-configs/blob/master/apollo/smartstack.yaml#L6-L8 if anyone wanted to use a template for some settings.
Since we now do this in paasta, and paasta knows how to filter templates (startingn with
_), we can finally fix this!We could also just update the schema but this was a 'smaller' change. I do agree it's a little hacky special-casing file types in validate_schema(), so lmk if there are strong opinions to go the other way.