Skip to content

Comments

Tweaked capitalisation of "BlendShape" to "Blendshape" for consistency.#96

Open
JackTheFoxOtter wants to merge 1 commit intoYellow-Dog-Man:masterfrom
JackTheFoxOtter:tweak-capitalisation
Open

Tweaked capitalisation of "BlendShape" to "Blendshape" for consistency.#96
JackTheFoxOtter wants to merge 1 commit intoYellow-Dog-Man:masterfrom
JackTheFoxOtter:tweak-capitalisation

Conversation

@JackTheFoxOtter
Copy link
Contributor

This resolves #59

Copy link
Member

@Frooxius Frooxius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this. But I should've mentioned that we should normalize them to "BlendShape", rather than "Blendshape".

In FrooxEngine we use "BlendShape" as intended capitalization, so this is now inconsistent with that, which makes things a bit weird.

Would you be able to swap it to other form?

@JackTheFoxOtter
Copy link
Contributor Author

I can when I find the time, but then it's not consistent with Submesh, which is called Submesh and not SubMesh... Should that also be changed? Also the JSON names are blendshape, and not blendShape. So those would need to be tweaked too. I feel like that would be more inconsistent with other stuff unless everything is changed.

@Frooxius
Copy link
Member

Frooxius commented Feb 5, 2026

Hmm... This is pain. We do capitalize "Submesh" like that in code too, but have "BlendShape".

So I guess we'll have to change those one way or the other if we want to have it consistent.

I'd say we'd change "Submesh" to "SubMesh" also. Looking at how Unity names their stuff, they do follow this convention:
https://docs.unity3d.com/ScriptReference/Mesh.SetSubMesh.html
https://docs.unity3d.com/ScriptReference/SkinnedMeshRenderer.GetBlendShapeWeight.html

EDIT: Also yes on changing the JSON name to match too.

@JackTheFoxOtter
Copy link
Contributor Author

All right! I'll look into updating it all when I find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent capitalisation for blendshapes

2 participants