Tweaked capitalisation of "BlendShape" to "Blendshape" for consistency.#96
Tweaked capitalisation of "BlendShape" to "Blendshape" for consistency.#96JackTheFoxOtter wants to merge 1 commit intoYellow-Dog-Man:masterfrom
Conversation
Frooxius
left a comment
There was a problem hiding this comment.
Thank you for making this. But I should've mentioned that we should normalize them to "BlendShape", rather than "Blendshape".
In FrooxEngine we use "BlendShape" as intended capitalization, so this is now inconsistent with that, which makes things a bit weird.
Would you be able to swap it to other form?
|
I can when I find the time, but then it's not consistent with Submesh, which is called Submesh and not SubMesh... Should that also be changed? Also the JSON names are blendshape, and not blendShape. So those would need to be tweaked too. I feel like that would be more inconsistent with other stuff unless everything is changed. |
|
Hmm... This is pain. We do capitalize "Submesh" like that in code too, but have "BlendShape". So I guess we'll have to change those one way or the other if we want to have it consistent. I'd say we'd change "Submesh" to "SubMesh" also. Looking at how Unity names their stuff, they do follow this convention: EDIT: Also yes on changing the JSON name to match too. |
|
All right! I'll look into updating it all when I find the time. |
This resolves #59