YH-1703: add Icon stories #1106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
user91123
commented
Feb 4, 2026
user91123
commented
- Скриншоты локи не сделаны, тк локи локально не смог запустить
src/shared/ui/Icon/Icon.stories.tsx
Outdated
| argTypes: { | ||
| icon: { | ||
| control: 'select', | ||
| options: [ |
Collaborator
There was a problem hiding this comment.
[ISSUE] - Тут можешь вместо массива указать Object.keys(icons). icons из соседнего файла icons.ts
src/shared/ui/Icon/Icon.stories.tsx
Outdated
| }, | ||
| }); | ||
|
|
||
| export const ArrowRight: Story = createIconStory('arrowRight'); |
Collaborator
There was a problem hiding this comment.
[ISSUE] - Не совсем так надо было. Сделать 1 сторю вместо всех что ниже
Назови ее All
Внутри createIconStory можешь просто промапать Object.keys(icons) и будет все красиво
Только отсортируй все иконки вначала по алфавиту
Цвета можешь не указывать, пускай по дефолту будут черные
PerelomaDenis
added
comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.