YH-1564: Add AnalyticsPageSkeleton component for all analytics pages #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shelterdef
added
review
- Rebase branch onto latest develop - Fix merge conflict in DifficultQuestionsPage - Add skeleton loading to all analytics pages
- Update question and quiz types from latest develop branch
Shelterdef
force-pushed
the
feature/YH-1564
branch
from
986dffa to
66ab94f
Compare
* YH-1594: Redesign tabs * YH-1594: Deleted Tabs_Line all files * YH-1538: Add deleteButtons in Topics page and functional * YH-1538: Fix delete funcional and conflicts
* YH-1494: Added campaign filtering to collection pages * YH-1494: Fixed it so that the component is only shown on the landing page and platform * YH-1494: fix fsd error * YH-1494: remove page * YH-1494: add page * YH-1494: fix companies select --------- Co-authored-by: Emin14 <emain-agjaev@mail.ru> Co-authored-by: Denis Pereloma <den.pereloma@gmail.com>
* YH-1453: Add users rating widget with mock API * YH-1453: refactor(analytics): update users rating API response and relocate users rating to user entity * YH-1453: fix(user): add cross imports from specialization to user entity * YH-1453: hide widget --------- Co-authored-by: Denis Pereloma <den.pereloma@gmail.com> Co-authored-by: PerelomaDenis <88330372+PerelomaDenis@users.noreply.github.com>
* YH-1594: Redesign tabs * YH-1594: Deleted Tabs_Line all files * YH-1594: fixed colors Tabs * YH-1594: fix styles --------- Co-authored-by: Denis Pereloma <den.pereloma@gmail.com>
PerelomaDenis
added
comments
* YH-1539: Added filter button and Pagination * YH-1539: Fixed comments
- Rebase branch onto latest develop - Fix merge conflict in DifficultQuestionsPage - Add skeleton loading to all analytics pages
Shelterdef
added
review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YH-1564: Add AnalyticsPageSkeleton component for all analytics pages
Извини за большое количество файлов в diff.
Фактические изменения только в 21 файле (7 новых скелетонов + 14 обновлений).
Остальные файлы — результат merge-конфликтов и истории ветки.
Я все еще плохо разбираюсь с Гитом, если это будет важно, то могу создать новую ветку. Я извиняюсь.
Касательно самой задачи:
Постарался учесть все твои комментарии, соблюсти структуру компонента в скелетоне. А также добавил рендер скелетона через Генератор скелетона.