YH-547: Added testing of the Accordion component #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emin14
added
review
| test('renders accordion with required props', () => { | ||
| render(); | ||
|
|
||
| expect(screen.getByTestId(AccordionTestIds.accordion)).toBeInTheDocument(); |
Collaborator
There was a problem hiding this comment.
Предлагаю вот эти проверки на наличие элементов разделить и дополнить доп проверки
Например в отдельный тест вынести
expect(screen.getByTestId(AccordionTestIds.title)).toBeInTheDocument();
И дополнительно сделать проверку на variant в зависимости от isMobile, на наличие класса
И также с теми элементами, на которые можно написать тест помимо обычного наличия
PerelomaDenis
added
comments
Emin14
force-pushed
the
feature/YH-547
branch
from
d5fdda5 to
6a85209
Compare
Emin14
added
review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.