Open
Conversation
wzjwzjwzjwzjwzj
requested review from
LazyJazz,
huanchenz,
qinchuanhui and
sshockwave
as code owners
LazyJazz
requested changes
Feb 28, 2023
Comment on lines
+5
to
+7
| class Tank : public Unit { | ||
| class Strangetank : public Unit { | ||
| public: | ||
| Tank(GameCore *game_core, uint32_t id, uint32_t player_id); | ||
| Strangetank(GameCore *game_core, uint32_t id, uint32_t player_id); |
Comment on lines
+5
to
+22
| class Tank : public Unit { | ||
| public: | ||
| Tank(GameCore *game_core, uint32_t id, uint32_t player_id); | ||
| void Render() override; | ||
| void Update() override; | ||
| [[nodiscard]] bool IsHit(glm::vec2 position) const override; | ||
|
|
||
| protected: | ||
| void TankMove(float move_speed, float rotate_angular_speed); | ||
| void TurretRotate(); | ||
| void Fire(); | ||
| [[nodiscard]] const char *UnitName() const override; | ||
| [[nodiscard]] const char *Author() const override; | ||
|
|
||
| float turret_rotation_{0.0f}; | ||
| uint32_t fire_count_down_{0}; | ||
| uint32_t mine_count_down_{0}; | ||
| }; |
Comment on lines
+1
to
+2
| #include "strange_tank.h" | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
一定概率暴击+吸血