Первая попытка сдачи промежуточного задания#24
Open
Shtainbook wants to merge 1 commit intoYandex-Practicum:mainfrom
Open
Первая попытка сдачи промежуточного задания#24Shtainbook wants to merge 1 commit intoYandex-Practicum:mainfrom
Shtainbook wants to merge 1 commit intoYandex-Practicum:mainfrom
Conversation
lugingf
approved these changes
Dec 11, 2023
lugingf
left a comment
lugingf
left a comment
There was a problem hiding this comment.
Принято, но с ignore обязательно надо разобраться и поправить.
There was a problem hiding this comment.
игнор по идее в корне проекта должен быть
There was a problem hiding this comment.
Ну а тут всю папку в игнор, потому что этих файлов не должно быть в репе
| "fmt" | ||
| "github.com/Yandex-Practicum/final-project-encoding-go/models" | ||
| "gopkg.in/yaml.v3" | ||
| "os" |
There was a problem hiding this comment.
Между импортами стандартной либы и сторонними должна быть пустая строка
| err = os.WriteFile(j.FileOutput, yamlData, 0644) | ||
|
|
||
| if err != nil { | ||
| fmt.Printf("ошибка при записи содержимого yamlData: %s\n", err.Error()) |
There was a problem hiding this comment.
Вообще по всем ошибкам - лучше ошибку оборачивать с комментарием, например с помощью fmt.Errorf("бла бла бла: %w", err)
А логи писать если надо что-то уточнить или отдебажить
There was a problem hiding this comment.
не уверен что эти файлы должны быть в репо
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.