Практическая работа: сервис для конвертации данных#17
Open
Ralphiko wants to merge 1 commit intoYandex-Practicum:mainfrom
Open
Практическая работа: сервис для конвертации данных#17Ralphiko wants to merge 1 commit intoYandex-Practicum:mainfrom
Ralphiko wants to merge 1 commit intoYandex-Practicum:mainfrom
Conversation
just-musha
approved these changes
Dec 5, 2023
just-musha
left a comment
just-musha
left a comment
There was a problem hiding this comment.
Привет! Спасибо. Оставила пару предложений - убрать сгенерированные файлы из коммита и почитать про оборачивание ошибок. Работа принята.
| @@ -0,0 +1 @@ | |||
| {"version":"3","services":{"web":{"build":".","ports":["5000:5000"],"volumes":["/usercode/:/code"],"links":["database:backenddb"]},"database":{"image":"mysql/mysql-server:5.7","environment":["MYSQL_ROOT_PASSWORD=root","MYSQL_USER=testuser","MYSQL_PASSWORD=admin123","MYSQL_DATABASE=backend"],"volumes":["/usercode/db/init.sql:/docker-entrypoint-initdb.d/init.sql"]}}} No newline at end of file | |||
There was a problem hiding this comment.
В этом задании все файлы генерируются в процессе работы программы.
Обычно в таком случае файлы не принято коммитить их в репозиторий, в репе хранится только код.
Кому нужно - скачивает код, запускает у себя и получает файлы. Так что предлагаю убрать их из комита и оставить только encoding.go
| // ... | ||
| jsonContent, err := ioutil.ReadFile(j.FileInput) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Если интересно как можно сделать ошибку более информативной - можешь посмотри про оборачивание ошибок в Go https://dotzero.blog/golang-113-errors/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.