Split PDF export into multiple files #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## 变更内容 ### 1. pdfExportManager.js - 新增完整的 PDF_STYLES 常量定义并导出 - 作为统一的样式配置来源 - 添加注释说明其作为常量定义中心的职责 ### 2. pdfContentRenderers.js - 删除本地 PDF_STYLES 定义（38行） - 改为从 pdfExportManager 导入 PDF_STYLES - 保持所有渲染函数逻辑不变 ### 3. pdfTextHelpers.js - 删除本地 PDF_STYLES 定义（42行） - 改为从 pdfExportManager 导入 PDF_STYLES - 保持所有文本处理和页面管理函数不变 ## 重构效果 - ✅ 消除重复：PDF_STYLES 只定义一次 - ✅ 职责清晰：pdfExportManager 作为常量和流程协调中心 - ✅ 减少代码：净减少 30 行重复代码 - ✅ 保持稳定：分页、渲染等核心逻辑完全不变 ## 模块依赖关系 pdfExportManager.js (导出 PDF_STYLES) ├─ 被 pdfContentRenderers.js 导入 └─ 被 pdfTextHelpers.js 导入
## 问题 - package.json 中 homepage 配置为 'https://yalums.github.io/dev' - 但字体路径硬编码为 '/lyra-exporter/fonts/...' - 导致部署后字体加载失败 (404 错误) ## 修复 将所有字体路径从 '/lyra-exporter/fonts/' 更新为 '/dev/fonts/'： - addChineseFontSupport() 中的 fontConfigs - preloadFont() 中的 fontPaths ## 影响 - ✅ 字体路径与 homepage 配置一致 - ✅ 部署到 GitHub Pages 后字体可正常加载 - ✅ PDF 导出功能中文显示正常
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.