Skip to content

Uifix/diyakithani#84

Merged
yalrubaye merged 18 commits intomainfrom
uifix/diyakithani
Dec 25, 2025
Merged

Uifix/diyakithani#84
yalrubaye merged 18 commits intomainfrom
uifix/diyakithani

Conversation

@diyakithani
Copy link
Collaborator

This PR refactors and improves the Mentor and Programs pages for better layout and accessibility compliance.
Key changes:

Mentor page

  • Centered hero image and both “Apply Now” buttons

  • Fixed aria-label typo and button accessibility

  • Cleaned and organized Mentor.scss

Programs page

  • Enhanced content clarity and fixed spelling qnd grammar issues

  • Rebuilt Programs.scss for better spacing, card-like design, and responsiveness

  • Ensured strong color contrast as the texts are large

@F-Hejazi
Copy link
Collaborator

Hi Diya,

Thanks for the work on these UI refinements. I noticed a couple of areas where we could make it more consistent:

  • Responsiveness: On the mentor page, both .text-content and .image-content now use flex: 0 1 520px. This introduces a fixed width that can cause the layout to overflow or compress awkwardly on mid-sized screens. It would be better to keep these flexible so they scale smoothly between breakpoints.

  • Button consistency: The programs page button uses a yellow background and adds a scale/translate hover effect. Elsewhere on the website, buttons are orange or green and only change color slightly on hover. Let’s align both the color and hover behavior so buttons feel consistent across pages.

  • Spacing: Some areas feel slightly different in terms of side padding and card separation. We need to make sure margins around cards and side gutters are consistent across pages.

Overall, I like the direction. Aligning these details will make the design feel even more polished and unified.

@DeMentidDev
Copy link
Collaborator

I would like to recommend pulling from main so that you can have the CI / build (pull_request) check pass without issue!

@yalrubaye yalrubaye merged commit c9fd715 into main Dec 25, 2025
1 check passed
@F-Hejazi F-Hejazi deleted the uifix/diyakithani branch December 29, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants