-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 기록 수정 감정 선택 UI 개선 #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. subemotion을 서버에서 내려주는 이유가 app 단에서 데이터 안갖고 받은 데이터 그대로 뿌릴려고 그랬던 거 같은데, << 이게 맞다면 SubEmotion이 어떤 String으로 구성되면 안될 것 같습니다. 정책을 명확하게 기억하는 상태가 아니라 이거 AOS쪽에 물어보고 후속 작업하시는 거 어떠실까요?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. SubEmotion이 이것저것 하다 남은 레거시 코드네요. 실제로는 사용중이지 않아서 삭제하겠습니다 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DetailRecordV2ResponseDTO 따로 안없애고 그냥 두 개로 두는 걸까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
각자 쓰이는 곳이 있어서 이후에 리팩토링하면서 정리할게요