You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Behaves exactly the same if no Remnants.cfg is not provided or does not exist. Allows .jar to be called from system wide install with no write permissions, and save/cfg/temp file directory in user folders, like $XDG_CONFIG_HOME
Indeed, the initialization of the new path is done too late.
Consequently, the new path is called twice before being initialized!
leading to a possible crash when chosing a Bitmap galaxy and trying to select a file.
in rotp.java: Moving "UserPreferences.setCfgPath(cfgFile);"" to line 143 only solve half the problem!
The UserPreferences class initialization request a call to this path! There is no way to place this basic parameter in UserPreferences... It must be located in rotp.
I would recommend declining the pull request!
Notes:
This is a complex change for a non issue: Just placing the game file in a writable folder solve everything!
I wouldn't want to encourage continuing in this direction either:
Currently, placing the game in the wrong directory results in a simple question and a simple answer, solving the problem.
With these kinds of changes, new users might not be notified and would unwittingly become beta testers... This will probably lead to a lot of problems, because the basic testing hasn't been done thoroughly enough!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaves exactly the same if no Remnants.cfg is not provided or does not exist. Allows .jar to be called from system wide install with no write permissions, and save/cfg/temp file directory in user folders, like $XDG_CONFIG_HOME