feat(llm): update default OpenAI model to gpt-5.4#262
Conversation
Remove all SpoonAgentRegistry dependencies from the Python SDK. The ERC-721 IdentityRegistry is now the sole identity contract. - erc8004_client.py: remove agent_registry_address param, old EIP-712 methods (create_eip712_signature, resolve_agent by didHash, update_capabilities, calculate_did_hash), and all legacy did-string methods. Add new resolve_agent(agent_id) using IdentityRegistry. - erc8004_abi.py: remove AGENT_REGISTRY_ABI, add agentExists to IDENTITY_ABI_MIN. - did_resolver.py: rewrite to accept agent_id (int) instead of DID string. Uses ownerOf/tokenURI/getMetadata from IdentityRegistry. - did_models.py: remove did_hash and registered_at fields. - eth_neofs_indexer.py: switch from AgentRegistry events to IdentityRegistry Registered events. - Remove NEOX_AGENT_REGISTRY from .env.example and examples.
Change default OpenAI provider model from gpt-4.1 (invalid) to gpt-5.4 to match current API availability.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
spoon-core/spoon_ai/identity/erc8004_client.py
Lines 141 to 145 in f775a4a
Restore legacy client helpers still used internally
This rewrite leaves ERC8004Client without the helper methods submit_reputation, submit_validation, get_reputation, and calculate_did_hash, but internal callers still invoke them (spoon_ai/identity/attestation.py:105,124,145,187,212). As a result, submitting on-chain attestations or calculating trust scores now raises AttributeError at runtime. Add compatibility wrappers (or migrate those callers in this same commit) to avoid breaking the exported identity APIs.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| Returns dict with owner, tokenURI, and common metadata fields. | ||
| """ | ||
| exists = self.identity_registry.functions.agentExists(agent_id).call() |
There was a problem hiding this comment.
AttestationManager.verify_attestation still calls resolve_agent(attestation.issuer) with a DID string (spoon_ai/identity/attestation.py:77), but this implementation now treats the argument as a numeric agent_id and immediately passes it to agentExists. That mismatch raises in Web3 type encoding, so verification falls into the exception path and valid attestations are reported as invalid. Please keep a DID-to-agentId compatibility path (or update all attestation callers in the same change).
Useful? React with 👍 / 👎.
1 participant
Summary
gpt-4.1(invalid model ID) togpt-5.4Test plan