Fix: Harden sandbox chat attachments, session history, and stream lifecycle by joeqian10 · Pull Request #39 · XSpoonAi/spoon-bot

joeqian10 · 2026-03-18T10:22:59Z

Description

This PR improves spoon-bot behavior in sandbox chat by fixing stale request leakage, making attachment handling workspace-safe, and preserving structured attachment context across session/history flows.

What this PR changes

makes anti-loop think() wrapping request-scoped instead of stacking across requests
restores the agent’s base think() implementation after process, stream, and process_with_thinking
cancels background run() tasks when a streamed request is cancelled or the stream is closed
avoids persisting partial/cancelled streamed output into session history
adds support for structured attachments alongside media in websocket and REST chat entrypoints
allows attachment-only chat requests and injects attachment context into the request when needed
validates attachment/media paths against the sandbox workspace instead of accepting arbitrary local files
validates imported session attachment/media metadata before persisting it
persists attachments and media in session history instead of flattening everything to plain text
rehydrates session history back into runtime memory with attachment context preserved
logs warnings when persisted attachment/media refs are dropped during history sync
improves multimodal/media error visibility by no longer silently swallowing invalid file refs

Why

Before this change, sandbox conversations could drift in a few bad ways:

a new request could inherit anti-loop prompt state from a previous request
cancelled streams could keep running in the background
attachment metadata could be available for the current request but get lost in later turns, reconnects, or session import/export
gateway callers could pass arbitrary existing local paths as media / attachments
invalid file refs could quietly degrade into text-only behavior

Together, these issues made sandbox attachment-based answers unreliable and could cause cross-request task leakage.

Expected result

stopping or disconnecting a stream no longer leaves the previous task running
a new chat starts from clean per-request state
attachment-only sandbox requests work consistently
structured attachment context survives session save/export/import/history hydration
only real files inside the configured workspace are accepted as attachment/media inputs
invalid attachment refs fail fast instead of degrading silently

…d media metadata

veithly · 2026-03-19T03:46:29Z

@codex review it

chatgpt-codex-connector

💡 Codex Review

spoon-bot/spoon_bot/gateway/api/v1/agent.py

Line 736 in 0b44b0b

_stream_sse(agent, processed_message, None, False, session_key=session_key),

Pass the new thinking argument in voice streaming

After _stream_sse() gained the new attachments positional parameter, this streaming call was not updated. POST /v1/agent/voice/chat with stream=true will now raise TypeError (missing 1 required positional argument: 'thinking') before any bytes are sent, so voice streaming is completely broken on this path.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

spoon_bot/gateway/websocket/handler.py

spoon_bot/gateway/models/requests.py

spoon_bot/gateway/api/v1/agent.py

…ming

joeqian10 · 2026-03-19T04:28:11Z

@codex review again and resolve conversations

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04724ebf2b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

spoon_bot/agent/loop.py

… history

joeqian10 · 2026-03-19T06:43:55Z

@codex review again

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 289ff98a99

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

spoon_bot/gateway/websocket/handler.py

chatgpt-codex-connector · 2026-03-19T06:50:45Z

spoon_bot/gateway/websocket/handler.py

+                        extras["media"] = _validate_media_paths(_string_list_from_any(extras.get("media")))
+                    if "attachments" in extras:
+                        extras["attachments"] = _validate_attachment_paths(
+                            _normalize_attachment_refs(extras.get("attachments"))
+                        )


Validate imported attachment refs before clearing the session

These new import-time validations run after session.messages.clear() has already executed a few lines above. That means an import with one bad media or attachments path now returns an error but leaves the existing session emptied in memory, so a failed session.import can destroy the user's current history. Build and validate the replacement message list first, then swap it into the live session only after validation succeeds.

Useful? React with 👍 / 👎.

joeqian10 · 2026-03-19T07:00:43Z

@codex review and list all the issues at one time

chatgpt-codex-connector

💡 Codex Review

spoon-bot/spoon_bot/gateway/websocket/handler.py

Lines 1077 to 1081 in e71b96a

    
           except Exception as e: 
        
               logger.error(f"Session import failed: {e}") 
        
               return { 
        
                   "success": False, 
        
                   "error": f"Import failed: {e}",

Stop swallowing session.import validation errors

This except Exception converts bad media/attachments imports into a normal {"success": false} response instead of the standard WS error frame. handle_request() only emits type: "error" / INVALID_PARAMS when a ValueError escapes, so clients that rely on WS error semantics will miss invalid import failures and can treat the import as successful. This happens for any session.import payload containing an out-of-workspace or missing file reference.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-19T07:07:43Z

spoon_bot/gateway/websocket/handler.py

+        resolved = _resolve_workspace_file(path)
+        if resolved is None:
+            invalid.append(path)
+            continue
+        resolved_media.append(str(resolved))


Preserve portable media URIs instead of host paths

By replacing each accepted media entry with str(resolved), the request loses the original /workspace/... URI and stores a host-specific absolute path instead. AgentLoop persists that list verbatim and session.export returns it verbatim, while session.import revalidates media against the current workspace root; as a result, a session exported from one sandbox/workspace will fail to import into another even when the same file exists there. This breaks round-tripping for any conversation that included media.

Useful? React with 👍 / 👎.

…ror semantics

fix: restrict attachment refs to workspace files and validate importe…

0b44b0b

…d media metadata

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

spoon_bot/gateway/websocket/handler.py Outdated Show resolved Hide resolved

spoon_bot/gateway/models/requests.py Show resolved Hide resolved

spoon_bot/gateway/api/v1/agent.py Outdated Show resolved Hide resolved

fix(spoon-bot): restore gateway attachment validation and voice strea…

04724eb

…ming

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

spoon_bot/agent/loop.py Show resolved Hide resolved

spoon_bot/agent/loop.py Outdated Show resolved Hide resolved

fix(spoon-bot): preserve attachment refs and raw user text in session…

289ff98

… history

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

fix(spoon-bot): normalize ws media paths and make session import atomic

e71b96a

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

fix(spoon-bot): preserve portable ws media URIs and restore import er…

a33ac13

…ror semantics

joeqian10 merged commit 8e5b4d2 into master Mar 19, 2026
1 of 2 checks passed

joeqian10 deleted the fix/chat_attachment branch March 19, 2026 07:15

	except Exception as e:
	logger.error(f"Session import failed: {e}")
	return {
	"success": False,
	"error": f"Import failed: {e}",

Conversation

joeqian10 commented Mar 18, 2026

What this PR changes

Why

Expected result

Uh oh!

veithly commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joeqian10 commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

joeqian10 commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

joeqian10 commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants