Add support for terminal related methods in web socket connection#32
Merged
Add support for terminal related methods in web socket connection#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add runtime-backed terminal session support to the websocket gateway by implementing
term.open,term.input,term.resize, andterm.closeinspoon-bot.Changes
WorkspaceTerminalServiceto manage connection-scoped terminal sessions inside the runtime workspacecwd,shell,cols,rows, andenvsandbox.stdoutterm.closedWhy
The API layer already forwards
term.*methods and normalizes terminal events, but the runtime did not actually provide terminal sessions. This PR closes that gap so the frontend can use interactive sandbox terminals instead of relying on mocked behavior or unsupported methods.Validation
python -m py_compile spoon_bot/gateway/websocket/workspace_terminal.py spoon_bot/gateway/websocket/handler.py spoon_bot/gateway/websocket/protocol.py tests/test_workspace_terminal_service.pyterm.open -> term.input -> sandbox.stdout -> term.closedNotes