DO NOT MERGE - RFC for changes to xmltv.dtd for audio description of visuals#260
Open
garybuhrmaster wants to merge 1 commit intoXMLTV:masterfrom
Open
DO NOT MERGE - RFC for changes to xmltv.dtd for audio description of visuals#260garybuhrmaster wants to merge 1 commit intoXMLTV:masterfrom
garybuhrmaster wants to merge 1 commit intoXMLTV:masterfrom
Conversation
Contributor
Author
|
Accidentally closed while doing other cleanup (too many branches, not enough time?). Reopened for possible further discussion/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This is a RFC to discuss adding a notification that the content has a Descriptive Video Service.
This was discussed on the xmltv-devel list as an enhancement.
In my interpretation of the discussion there seemed to be a general agreement that while in an ideal world one might add additional elements to the program, that is probably not possible in the short term because at least some applications would likely break. Adding an additional attribute to the subtitles element seemed to be the least impactful way to get the information available to applications (when the upstream guide data provided it) to use today. The name of the attribute itself is completely arbitrary as long as it has a proper definition in the dtd such that grabbers and applications agree on it's usage. I would argue that we should not let the perfect solution be the enemy of the good enough, and just do something like this.
Comments (strongly) encouraged.