Simplify provider request handling flow #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move provider request detection into Composer component using useProviderRequest hook - Add auto-compose for provider requests (skip form, go straight to review) - Remove denormalization - provider data passed directly in API format - Use ApprovalService proxy instead of direct safeSendMessage calls - Add auto-navigation for compose requests on index page - Add hideBackButton prop to ReviewScreen for provider requests - Remove resolve-provider-request handler from background script - Simplify ProviderService and ConnectionService (-213 lines)
droplister
force-pushed
the
refactor/provider-request-flow
branch
from
e3015d9 to
3af3be7
Compare
- Update @playwright/test to 1.57.0 (fixes SSL cert verification) - Update happy-dom to 20.0.11 (fixes VM context escape RCE) - npm audit fix for glob, js-yaml, node-forge, vite vulnerabilities
- Fix providerService.test.ts: Update regex pattern to match actual compose operation ID format (compose-compose-send-xxx) - Fix ApprovalService.test.ts: Update badge color assertion to match implementation (#3B82F6 instead of #EF4444) - Fix ConnectionService.test.ts: Add mock for getApprovalService and emit method on eventEmitterService to avoid chrome.runtime errors
Add mock for webext-bridge/background before importing Composer component to prevent Browser.runtime.onConnect.addListener error.
Add NODE_OPTIONS=--max_old_space_size=4096 to prevent out-of-memory crashes when running the full test suite in CI.
The component imports from @/utils/blockchain/counterparty/api but the test was mocking @/utils/blockchain/counterparty.
The form component imports from @/utils/blockchain/counterparty/api and @/utils/blockchain/counterparty/memo, not the base path.
Use || true to capture vitest exit even if process crashes from OOM, then check test-results.json for actual pass/fail status. This handles the case where all tests pass but Node.js runs out of memory during teardown/reporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Composercomponent viauseProviderRequesthookApprovalServiceproxy instead of directsafeSendMessagecalls for cleaner approval handlingTest plan