Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…e/codex-add-interactive-code-diff-visualizations-nqufce
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9aefe808e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import plotly.graph_objects as go | ||
| import streamlit as st | ||
| import urllib | ||
| from st_diff_viewer import diff_viewer |
There was a problem hiding this comment.
The new from st_diff_viewer import diff_viewer import will raise ModuleNotFoundError in a clean environment because this dependency is not declared in pyproject.toml or uv.lock (I searched both). That means the Streamlit app will crash at startup unless users happen to have the package installed globally. Please add the dependency or gate the import.
Useful? React with 👍 / 👎.
| if parent is not None: | ||
| lineage.append(parent) | ||
| pid = parent["parent_ids"] | ||
| if pid: |
There was a problem hiding this comment.
get_code_lineage sets parent = None when an ID is missing, but immediately dereferences parent["parent_ids"]. If the dataset is filtered or missing ancestors (common when viewing a subset of runs), this will crash instead of returning the partial lineage. Consider breaking/raising when parent is None before accessing its fields.
Useful? React with 👍 / 👎.
2 participants
Summary
Testing
uv run pytest tests/https://chatgpt.com/codex/tasks/task_e_68b747ddfca0832198dcdb7910765db6