Open
Conversation
mixiate
force-pushed
the
fix-msvc-build-errors
branch
from
7b4027a to
31db933
Compare
mixiate
force-pushed
the
fix-msvc-build-errors
branch
from
203e82d to
bf4263a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a couple of issues when using MSVC on windows.
Removes the statically linked standard library due to crashes in libpng.
It adds the
/Zc:enumTypesflag so that enums are automatically sized to their largest member. Needed for enum flags over 32 bits.Reformats a couple of pragma warnings causing a build error to be on separate lines.
Moves a function call out of an assert so that it doesn't get skipped if asserts are off.