1.0.0: TypeScript rewrite with dual CJS/ESM output#17
Merged
Conversation
Owner
Wozacosta
commented
Mar 29, 2026
Wozacosta
commented
- Convert source to TypeScript with full exported types (NaivebayesOptions, CategorizeResult, Likelihood, InfluentialToken, etc.)
- ES6 class-based implementation, same public API preserved
- Dual CJS/ESM output via tsup (esbuild-based)
- Type declarations (.d.ts) included for TypeScript consumers
- Migrate tests from Mocha+assert to Vitest+expect (109 tests)
- CI: Node 18/20/22 with typecheck + build + test steps
- Minimum Node version raised to 18.0.0
- Convert source to TypeScript with full exported types (NaivebayesOptions, CategorizeResult, Likelihood, InfluentialToken, etc.) - ES6 class-based implementation, same public API preserved - Dual CJS/ESM output via tsup (esbuild-based) - Type declarations (.d.ts) included for TypeScript consumers - Migrate tests from Mocha+assert to Vitest+expect (109 tests) - CI: Node 18/20/22 with typecheck + build + test steps - Minimum Node version raised to 18.0.0
- Add "type": "module" to package.json (required by Vite/Vitest) - Update export paths: .cjs/.js instead of .js/.mjs
- Fix CRITICAL: tsup footer injected module.exports into ESM output, breaking all ESM imports. Now patches only the CJS file via onSuccess. - Add 12 dist output tests verifying CJS require, ESM import, named exports, serialization round-trip, and .d.ts type declarations. - Document all exported TypeScript types in README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.