changes to our defaults require the modification of postalAddress and email template#14
Merged
rodrigoAbril merged 26 commits intomainfrom Feb 6, 2026
Conversation
This was referenced Dec 5, 2025
- Introduced a new module for Netherlands country handling. - Created `Postage` class to define postage zones: NL, EUROPE, and REST_OF_WORLD. - Implemented `CountryMapping` and `Country` classes to manage country data. - Added logic in `Country` class to determine postage zone based on canonical name. - Defined `CountryNotFoundError` for handling country lookup errors.
… adjust postage logic
…cipient CSV handling - Implemented tests for validating Dutch addresses, including handling of international addresses and postcode parsing. - Added tests for letter timings to ensure correct delivery estimates based on upload times. - Created tests for recipient CSV processing, including validation of address data and handling of errors for missing or incorrect information. - Utilized parameterized tests to cover various scenarios and edge cases for comprehensive coverage.
…and-postalAddress-changes
rodrigoAbril
added
the
dutchification
pgaetani
reviewed
Jan 30, 2026
pgaetani
reviewed
Jan 30, 2026
notifications_utils/recipient_validation/notifynl/postal_address.py
Outdated
Show resolved
Hide resolved
pgaetani
reviewed
Jan 30, 2026
pgaetani
reviewed
Jan 30, 2026
…ddress-changes' of github.com:Worth-NL/notifynl-utils into notifyNL-changes-to-email-branding-defaults-and-postalAddress-changes
…e and add corresponding test case
…ddress line changes
- removed GOV.UK banner to the Dutch email template for improved branding. - Removed unnecessary conditional comments for Microsoft Outlook compatibility. - Updated the address line keys in the template module from 1-7 to 1-6 to reflect changes in recipient validation.
… 6 instead of line 7
…te related functions
…n and adding international address tests
… in recipient column handling
pgaetani
approved these changes
Feb 6, 2026
rodrigoAbril
deleted the
notifyNL-changes-to-email-branding-defaults-and-postalAddress-changes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes to email template default and fixes for postal address so we better override the uk one.
Related to Worth-NL/notifynl-admin#31 — requires additional testing after merge
Related to Worth-NL/notifynl-admin#32 — requires additional testing after merge
Related to Worth-NL/notifynl-admin#41 — requires additional testing after merge