Fix redirect comparison to account for port difference #8977
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
tests/phpunit/tests/canonical.php
Outdated
| ), | ||
| ); | ||
| } | ||
| public function test_redirect_non_standard_localhost_port_to_canonical_domain() { |
There was a problem hiding this comment.
Can you add grouping with the ticket for all the tests that are relevant to #33821
Like
/* @ticket 33821
Also, will be good to add some little doc comments along with the ticket grouping
Like
/**
* Test redirecting a non-standard localhost port to the canonical domain.
*
* @ticket 33821
*/
For all the provided tests.
tests/phpunit/tests/canonical.php
Outdated
| update_option( 'home', 'http://example.com' ); | ||
| update_option( 'siteurl', 'http://example.com' ); | ||
|
|
||
| // Simulate a request to a non-canonical domain |
There was a problem hiding this comment.
Also its not required because phpunit doesnt have strict PHPCS rules, but ending comments in a full-stop is a good practice.
There was a problem hiding this comment.
Actually, we do not need to simulate those $_SERVER variable here. They are used to assemble $request_url only when it's not provided to the function, but in all our tests we provide it. I cleaned that up.
|
@wojtekn why have you closed this? |
|
@SirLouen oh, I didn't intend to close that. It seems it was auto-closed when I cleaned my unused forks. I see this change was approved last year, but haven't made a way to core. What would be good next step? |
|
@wojtekn I see it was not milestoned. Reopen the PR or send a new PR and I will milestone it for 7.0 |
2 participants
Fix redirect comparison to account for port difference to ensure redirects from a requested URL that uses port to a canonical URL that doesn't use port work correctly.
Trac ticket: https://core.trac.wordpress.org/ticket/33821
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.